Warn against fully-qualified Closes owner/repo#N in PR bodies#85
Merged
Conversation
Member
Author
Review SummaryVerdict: APPROVE FindingsNo issues found. Code looks correct and follows project conventions. The change adds a consistent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub's closing-keyword parser only populates
closingIssuesReferencesfor the unqualified#Nform. The fully-qualifiedCloses owner/repo#Nform (even for same-repo refs) leaves that GraphQL edge empty, silently breaking native auto-close and downstream automation that reads the edge.General harness guidance often nudges agents toward
owner/repo#Nas a universal cross-link format. This change adds explicit overrides in the two places that build PR bodies —/submit-for-reviewand/deploy— telling agents to use the unqualified form for closing keywords regardless of that general guidance.Scope note: the original issue #80 described four gaps, but the other three (label-linked-issues.yml trigger, duplicate "Ready for Review" label scheme, missing close-on-qa-passed automation) do not apply to the current Code Cannon scaffolding — there is no such workflow in this repo, no duplicate label scheme, and closure is intentionally driven by
/deploy's promotion PR rather than theqa-passedlabel (see docs/skills/deploy.md). The only real gap was the qualified-form footgun, which this PR fixes.Issue #80